Question

Parameter index out of range (5 > number of parameters, which is 3)

//获取页面修改之前的信息（部分代码）
String sid = req.getParameter("id");
int id = Integer.parseInt(sid);

String name = req.getParameter("name");
String pass = req.getParameter("pass");
System.out.println(name+"-----------"+pass);
UserDTO userDTO = new UserDTO();

userDTO.setName(name);
userDTO.setPassword(pass);

//sql
String sql = "update p_user set name = ?,password = ?, where id = ?";
Dao dao = new Dao();
int count = dao.getUpdate(sql, userDTO);
String url = "";
if(count > 0){
url = "userList.jsp";
}else{
url = "error.jsp";
req.setAttribute("error", "更新");
}
req.getRequestDispatcher(url).forward(req, resp);

dao层
public int getUpdate(String sql,UserDTO userDTO){
int count = 0;
try {
pre = connection.prepareStatement(sql);
pre.setInt(5,userDTO.getId());
pre.setString(1, userDTO.getName());
pre.setString(2, userDTO.getPassword());
} catch (SQLException e) {
// TODO Auto-generated catch block
e.printStackTrace();
}
finally
{
try{
pre.close();
connection.close();
} catch (SQLException e) {
// TODO Auto-generated catch block
e.printStackTrace();
}
}
return count;
}
上面多一个逗号，我已经删掉，那里不是主要原因，
Parameter index out of range (5 > number of parameters, which is 3)

Answer 1

pre.setInt(5,userDTO.getId());
这里面的第一个参数对应你上面sql语句里面的第几个问号,
（5 > number of parameters）你一共只有3个问号，所以只能这个数字最大只能是3。5超出最大范围了

所以你可以改成：
pre.setInt(3,userDTO.getId());
或者直接用字段名：
pre.setInt("id",userDTO.getId());

Answer 2

还有一种情况一共有5个问号，前面三个英文输入的?号，后面两个可能用的中文输入的？.

Answer 3

问题很明显吧 你只有三个参数 那个下标 5 不就越界了？

pre = connection.prepareStatement(sql);
pre.setInt(5,userDTO.getId()); ----》 pre.setInt(3,userDTO.getId());
pre.setString(1, userDTO.getName());
pre.setString(2, userDTO.getPassword());

Answer 4

这句pre.setInt(5,userDTO.getId());应该是pre.setInt(3,userDTO.getId());吧,把5改成3就应该行了.